Create RETIRED.txt

As of nginx 1.23 the cache control headers are re-implemented as al linked list.
This reworks our code that manipulates this header to work with that.

Still a draft: this change probably needs to be conditioned against nginx version
with ifdefs, so older version can still be built as well. Hence, still a draft.

Attempts to fix https://github.com/apache/incubator-pagespeed-ngx/issues/1749

README.md

@@ -1,4 +1,4 @@
-![ngx_pagespeed](https://lh6.googleusercontent.com/-qufedJIJq7Y/UXEvVYxyYvI/AAAAAAAADo8/JHDFQhs91_c/s401/04_ngx_pagespeed.png)
+![ngx_pagespeed](https://user-images.githubusercontent.com/6751650/73116078-338a9180-3f0f-11ea-8fdf-8c99cb4bec7f.png)
 
 [![Build Status](https://travis-ci.org/apache/incubator-pagespeed-ngx.svg?branch=master)](https://travis-ci.org/apache/incubator-pagespeed-ngx)
 

RETIRED.txt

@@ -0,0 +1 @@
+This podling has been retired, please see: http://incubator.apache.org/projects/index.html#pagespeed

scripts/format_binary_url.sh

@@ -1,4 +1,4 @@
-#!/bin/bash
+#!/bin/sh
 # Licensed to the Apache Software Foundation (ASF) under one
 # or more contributor license agreements.  See the NOTICE file
 # distributed with this work for additional information

src/ngx_pagespeed.cc

@@ -6,9 +6,9 @@
  * to you under the Apache License, Version 2.0 (the
  * "License"); you may not use this file except in compliance
  * with the License.  You may obtain a copy of the License at
- * 
+ *
  *   http://www.apache.org/licenses/LICENSE-2.0
- * 
+ *
  * Unless required by applicable law or agreed to in writing,
  * software distributed under the License is distributed on an
  * "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
@@ -396,6 +396,35 @@ namespace {
 //
 // Based on ngx_http_add_cache_control.
 ngx_int_t ps_set_cache_control(ngx_http_request_t* r, char* cache_control) {
+#if defined(nginx_version) && nginx_version >= 1023000
+  ngx_table_elt_t* cc = r->headers_out.cache_control;
+
+  if (cc == NULL) {
+
+      cc = reinterpret_cast<ngx_table_elt_t*>(ngx_list_push(&r->headers_out.headers));
+      if (cc == NULL) {
+          return NGX_ERROR;
+      }
+
+      r->headers_out.cache_control = cc;
+      cc->next = NULL;
+
+      cc->hash = 1;
+      ngx_str_set(&cc->key, "Cache-Control");
+
+  } else {
+      for (cc = cc->next; cc; cc = cc->next) {
+          cc->hash = 0;
+      }
+
+      cc = r->headers_out.cache_control;
+      cc->next = NULL;
+  }
+  cc->value.len = strlen(cache_control);
+  cc->value.data =
+      reinterpret_cast<u_char*>(cache_control);
+
+#else
   // First strip existing cache-control headers.
   ngx_table_elt_t* header;
   NgxListIterator it(&(r->headers_out.headers.part));
@@ -405,7 +434,6 @@ ngx_int_t ps_set_cache_control(ngx_http_request_t* r, char* cache_control) {
       header->hash = 0;
     }
   }
-
   // Now add our new cache control header.
   if (r->headers_out.cache_control.elts == NULL) {
     ngx_int_t rc = ngx_array_init(&r->headers_out.cache_control, r->pool,
@@ -429,7 +457,7 @@ ngx_int_t ps_set_cache_control(ngx_http_request_t* r, char* cache_control) {
   cache_control_headers[0]->value.len = strlen(cache_control);
   cache_control_headers[0]->value.data =
       reinterpret_cast<u_char*>(cache_control);
-
+#endif
   return NGX_OK;
 }
 
@@ -439,6 +467,23 @@ bool ps_get_cache_control(ngx_http_request_t* r, GoogleString* cache_control) {
   // Use headers_out.cache_control instead of looking for Cache-Control in
   // headers_out.headers, because if an upstream sent multiple Cache-Control
   // headers they're already combined in headers_out.cache_control.
+#if defined(nginx_version) && nginx_version >= 1023000
+  ngx_table_elt_t* cc = r->headers_out.cache_control;
+  bool first_segment = true;
+
+  while (cc != NULL) {
+    if (cc->hash) {
+      if (first_segment) {
+        first_segment = false;
+      } else {
+        cache_control->append(", ");
+      }
+      cache_control->append(reinterpret_cast<char*>(cc->value.data),
+                            cc->value.len);
+    }
+    cc = cc->next;
+  }
+#else
   auto ccp = static_cast<ngx_table_elt_t**>(r->headers_out.cache_control.elts);
   if (ccp == nullptr) {
     return false;  // Header not present.
@@ -456,6 +501,7 @@ bool ps_get_cache_control(ngx_http_request_t* r, GoogleString* cache_control) {
     cache_control->append(reinterpret_cast<char*>(ccp[i]->value.data),
                           ccp[i]->value.len);
   }
+#endif
   return true;
 }
 
@@ -1028,7 +1074,7 @@ void* ps_create_main_conf(ngx_conf_t* cf) {
   }
   ps_main_conf_t* cfg_m = ps_create_conf<ps_main_conf_t>(cf);
   if (cfg_m == NULL) {
-    return NGX_CONF_ERROR;
+    return NULL;
   }
   CHECK(!factory_deleted);
   NgxRewriteOptions::Initialize();
@@ -1049,7 +1095,7 @@ void* ps_create_main_conf(ngx_conf_t* cf) {
 void* ps_create_srv_conf(ngx_conf_t* cf) {
   ps_srv_conf_t* cfg_s = ps_create_conf<ps_srv_conf_t>(cf);
   if (cfg_s == NULL) {
-    return NGX_CONF_ERROR;
+    return NULL;
   }
   ps_set_conf_cleanup_handler(cf, ps_cleanup_srv_conf, cfg_s);
   return cfg_s;
@@ -1058,7 +1104,7 @@ void* ps_create_srv_conf(ngx_conf_t* cf) {
 void* ps_create_loc_conf(ngx_conf_t* cf) {
   ps_loc_conf_t* cfg_l = ps_create_conf<ps_loc_conf_t>(cf);
   if (cfg_l == NULL) {
-    return NGX_CONF_ERROR;
+    return NULL;
   }
   ps_set_conf_cleanup_handler(cf, ps_cleanup_loc_conf, cfg_l);
   return cfg_l;