7bd90f7b3a
Merge pull request #872 from pagespeed/jefftk-revert-834
...
Revert "NgxConnection: single event mechanism
2015-01-09 10:25:12 -05:00
73981ffe1a
Revert "NgxConnection: single event mechanism for NgxFetch and NgxBaseFetch"
...
This reverts commit 5dfe42f3d3
2015-01-08 13:02:19 -05:00
58228564dd
Merge pull request #869 from pagespeed/jefftk-system-moved
...
mod_pagespeed moved the location of the system directory; update our includes
2015-01-06 09:50:11 -05:00
340c86a49e
mod_pagespeed moved the location of the system directory; update our includes
2015-01-06 09:22:56 -05:00
abdafc7aa4
Merge pull request #834 from pagespeed/oschaaf-single-pipe2
...
NgxConnection: single event mechanism for NgxFetch and NgxBaseFetch
2014-12-30 21:52:07 +01:00
8cf10873d1
Merge pull request #863 from pagespeed/jmaessen-ngx-message-handler-fix
...
Make ngx_message_handler work with new message_handler api.
2014-12-19 16:13:26 -05:00
2496716e36
Make ngx_message_handler work with new message_handler api.
2014-12-19 15:11:55 -05:00
af364344e9
Merge pull request #862 from pagespeed/jefftk-rmdir
...
testing: give '-p' to mkdir
2014-12-17 12:55:44 -05:00
9da45910c7
rm won't remove the containing directory if a file is removed out from under it, which means the directory will still be there but will be empty. This is not a problem, so pass '-p' to not fail on already existing directories.
2014-12-17 12:50:23 -05:00
5dfe42f3d3
NgxConnection: single event mechanism for NgxFetch and NgxBaseFetch
...
Abstract the pipe communication into NgxEventConnection, for reuse
by NgxBaseFetch and NgxUrlAsyncFetcher.
Based on Chai's earlier work, but with a few fixes discovered
while working on this and SPDY module compatibility
- Uses less file descriptors, I expect this to be faster but need
measurement is needed to back that.
- Fixed NgxUrlAsyncFetcher actually shutting down its fetchers.
- Fixes a bug where we wouldn't clean idle pooled NgxConnections.
- Fixes a bug for requests that are finalized mid-IPRO lookup.
- Makes us use ngx_handle_read_event/ngx_del_event
2014-12-14 02:29:40 +01:00
bff15040be
Merge pull request #857 from pagespeed/jefftk-upstream-check-failure-function
...
Upstream the change to check_failures_and_exit, moving it to mod_pagespeed
2014-12-04 15:42:31 -05:00
3c5c5076de
Upstream the change to check_failures_and_exit, moving it to mod_pagespeed
2014-12-04 13:22:13 -05:00
eab4f8672f
Merge pull request #852 from pagespeed/jefftk-move-tests-to-system
...
Move duplicate tests from the nginx-specific system test to system
2014-12-02 20:12:52 -05:00
852e376130
Move duplicate tests from the nginx-specific system test to system/system_test
...
As system/system_test.sh is in the mod_pagespeed repo, this is just a bunch of
deletes.
2014-12-02 15:11:23 -05:00
b7529a8d9a
Merge pull request #855 from pagespeed/jefftk-fix-tempdir
...
Rework parallization separation
2014-12-02 13:34:03 -05:00
5dd93fffae
Rework parallization separation
2014-12-01 10:49:08 -05:00
48d23f10ba
Merge pull request #851 from pagespeed/jefftk-fix-url-purging
...
Fix error with url cache purging test. Followup to #850 .
2014-11-17 11:25:03 -05:00
f924bc72d9
Fix error with url cache purging test. Followup to #850 .
2014-11-17 11:19:51 -05:00
1aff187d0e
Merge pull request #850 from pagespeed/oschaaf-trunk-tracking-script-filters-test
...
script-filters: Add a test for modifying filters via script variables
2014-11-14 16:03:22 +01:00
3b64df255a
Merge pull request #849 from pagespeed/jefftk-prioritize-critical-css-test
...
testing: allow the prioritize_critical_css post test to fail
2014-11-14 10:02:49 -05:00
0eeeca6e47
script-filters: Add a test for modifying filters via script variables
...
As requested via https://github.com/pagespeed/ngx_pagespeed/pull/822
2014-11-14 15:56:13 +01:00
6f68ba2f68
testing: allow the prioritize_critical_css post test to fail
2014-11-14 08:56:37 -05:00
e6e70c32a8
Merge pull request #822 from pagespeed/oschaaf-trunk-tracking-script-filters
...
script-filters: Allow using script variables in Enable/DisableFilters
2014-11-06 22:35:44 +01:00
a3e20a05e2
Merge pull request #846 from pagespeed/oschaaf-trunk-tracking-conf-multi-typo
...
NGX_CONF_MULTI: Typo
2014-11-04 13:46:55 -05:00
e28255e2ef
NGX_CONF_MULTI: Typo
...
Fix accidental double pipe symbol.
Fixes https://github.com/pagespeed/ngx_pagespeed/issues/843
2014-11-04 13:29:49 +01:00
10ac8ae4a3
Merge pull request #798 from pagespeed/oschaaf-trunk-tracking-conf-multi
...
older-nginx-versions: Add NGX_CONF_MULTI to ps_command flags.
2014-10-30 15:13:27 +01:00
1b3ca08e22
Merge pull request #841 from pagespeed/crowell-tengine-stable-support
...
Check type of resolver_ctx->addrs.
2014-10-29 14:59:51 -04:00
de5bc5d943
Check type of resolver_ctx->addrs.
...
Check the type of resolver_ctx->addrs and make sure that it is
ngx_addr_t* instead of in_addr_t*. addresses issue #839
2014-10-29 14:49:55 -04:00
afd0f01686
script-filters: Allow using script variables in Enable/DisableFilters
...
To support a non-evil way (if-in-location) of tuning SPDY specific
configuration, allow scripting of Enable/DisableFilters in nginx.conf
2014-10-10 17:33:44 +02:00
0cdb81fab4
Merge pull request #795 from pagespeed/oschaaf-native-fetcher-remove-check
...
native-fetcher: remove a DCHECK that possibly fires on shutdown.
2014-10-06 17:04:56 +02:00
b492d3966e
Merge pull request #811 from pagespeed/cheesy-device-matching
...
Support minor PSOL API change for matches_device_type
2014-09-22 17:38:06 -04:00
232c05a81d
Merge remote-tracking branch 'origin/trunk-tracking' into cheesy-device-matching
2014-09-19 18:17:20 -04:00
adbe2cb359
Remove unit tests; They are now in system_test.sh
2014-09-19 18:14:18 -04:00
88370cf54d
Merge pull request #809 from pagespeed/crowell-update-config
...
Merge config from 1.9.32.1
2014-09-19 10:47:08 -04:00
b43a973071
Merge config from 1.9.32.1
2014-09-19 10:30:38 -04:00
a524127d49
PSOL API change and unit tests for matches_device_type
2014-09-18 18:22:46 -04:00
53a6de6da8
Merge pull request #797 from pagespeed/oschaaf-finalized-requests-fix
...
connection_read_handler: fix potential double free
2014-09-15 16:26:29 +02:00
66f1b9aa9b
older-nginx-versions: Add NGX_CONF_MULTI to ps_command flags.
...
Older nginx versions don't allow 'pagespeed' configuration
directives to appear in blocks other then http{} without it.
Fixes https://github.com/pagespeed/ngx_pagespeed/issues/786
2014-09-14 09:19:13 +02:00
6903286aa4
connection_read_handler: fix potential double free
...
In connection_read_handler(), make sure we act accordingly when
r->connection->error is set (indicating the the current request has
been finalized).
Reproduction of what happens when we don't: enable IPRO+SPDY, and
rapidly refresh a page with chrome. These rapid abortions will
eventually trigger a segfault/hang/misc bad behaviour.
2014-09-13 16:30:34 +02:00
46dc39f5a9
Merge pull request #794 from pagespeed/oschaaf-ipro-race
...
IPRO: Fix a race in processing writes() from NgxBaseFetch
2014-09-12 16:33:29 +02:00
7d8fefe780
native-fetcher: remove a DCHECK that possibly fires on shutdown.
2014-09-11 23:33:22 +02:00
43d1706e2f
IPRO: Fix a race in processing writes() from NgxBaseFetch
...
For FetchInPlaceResource, NgxBaseFetch would send two bytes down its
pipe, one upon HeaderComplete() and one upon HandleDone(). We need
only one to resume processing on the nginx side.
There is a race between ps_connection_read_handler() and processing
of the byte send by NgxBaseFetch::HandleDone().
ps_connection_read_handler() clears the pipe when the request is
finalized, and also drains it on each event - so two writes could be
processed as one when lucky, masking the problem).
One concrete problem this solved for me was that SPDY + IPRO +
proxy_pass would segfault, hang, and/or pass on 5xx/404 responses
from IPRO lookup fetches to the browser, next to alerts about
r->count being zero in nginx's error.log
Might fix https://github.com/pagespeed/ngx_pagespeed/issues/788
Fixes https://github.com/pagespeed/ngx_pagespeed/issues/792
2014-09-11 23:14:41 +02:00
622d088a3e
Merge pull request #790 from pagespeed/oschaaf-trunk-tracking-native-fetcher-keepalive
...
native fetcher: Support http keep-alive
2014-09-05 17:29:22 +02:00
0290f52a88
native fetcher: Support http keep-alive
...
Based on @dinic his work, add keep-alive support for the native fetcher.
Adds a new option, usable at the http{} level in configuration:
pagespeed NativeFetcherMaxKeepaliveRequests 50;
The default value is 100 (aligned to nginx). Setting the value to 1 turns off
keep-alive requests altogether).
Most notable changes:
- Request keep-alive by adding the appropriate request header
- Fixes connections getting reused while they are servicing other requests:
- Remove connection from the pool of available connections for keepalive when applicable
- Disable keepalive in more appropriate situations
- Response parsing fixes
- Remove connections that timeout from the k.a. pool
- Add a few sanity (D)CHECKS
- Emit debug messages for traceability
- Fix for ignoring ipv6 addresses returned from dns queries when ipv6 is enabled.
- Bump the fetch timeout in test configuration to deflake tests that require dns
lookups (which will be done via 8.8.8.8 currently for the native fetcher)
2014-09-05 17:23:16 +02:00
c94146a54d
Merge pull request #791 from pagespeed/morlovich-trunk-tracking-remove-deprecated-headers
...
Remove use of deprecated forwarding headers
2014-09-04 16:06:52 -04:00
f3a1cb6cf4
Remove use of deprecated forwarding headers
2014-09-04 09:16:05 -04:00
5a23347e64
Merge pull request #785 from pagespeed/jmarantz-error-option-format
...
Implement NgxServerContext::FormatOption so we can indicate nginx formatting in error messages
2014-08-29 16:32:43 -04:00
7ce289346a
Override the method used to specify the format for conf files, so we can put an accurate error message in the admin GUI, and test it
2014-08-29 09:13:43 -04:00
6b4a9dc487
Merge pull request #784 from pagespeed/jmarantz-fgrep-for-counts
...
use fgrep for counting ".pagespeed."
2014-08-27 09:47:46 -04:00
a3f2e4766c
use fgrep for counting ".pagespeed.", rather than grep with backslashed dot, which matches too much
2014-08-26 15:02:10 -04:00
Jeff Kaufman