* Add default setting for whether to test with a controller port.
* Use RUN_CONTROLLER_TEST, which will actually be defaulted in
system/system_test.sh. Comment out the controller port configuration
in the default nginx template.
* Finish up the conditionalization of the babysitter tests.
* Run the reload tests even with the controller off.
* clean up the diffs a little.
After calling ngx_http_filter_finalize_request return NGX_DONE
as we are still in pre-access phase. This bug shows up when the
"special" response is generated from, for example, php as opposed
to a static file.
Second part of the fix for
https://github.com/pagespeed/ngx_pagespeed/issues/1146
This change makes ngx_pagespeed listen to the FollowFlushes option.
When set to on (=default), ngx_pagespeed will forward incoming flushes
to ProxyFetch. When writing output, we'll now also set the flush flag on
the buffers we are about to send downstream.
Companion to mps commit: https://github.com/pagespeed/mod_pagespeed/commit/02de03e825bbd1f8d4ad4e1a1bef5263a16f3857
When there is no top-level configuration but only server configuration,
we don't have main options to set and consider. This prevents
a NULL dereference in that case. (Later on we'll writes out a message
about why we cannot startup with this configuration).
The renaming is to make it clear that kProcessScopeStrict (aka what
ngx_pagespeed does for everything already) is what new code should be
using, rather than current kProcessScope/upcoming kLegacyProcessScope
which does weird backwards compatible things in mod_pagespeed.
* Pass the install-path into Makefile, rather than having the Makefile
depend on PWD.
* Move the double-quotes be before the value, to be consistent with other
Makefiles.
Instead, use a new (not-yet-committed) target in Makefile.tests to build
a mirror htdocs in test/tmp/root that sym-links the large readonly
section and deep copies the test areas for purge and flush tests.
This change makes nginx close the request when we receive a close
event or RST_STREAM while waiting for an async PSOL op to complete
by setting a read event handler, as inspired by the limit request
module from nginx.
Should fix https://github.com/pagespeed/ngx_pagespeed/issues/1146
Explain why we do it via config.make better.
Remove partial workaround for config.make not invoked for dynamic modules,
nginx dev fixes the root issue, and the workaround is insufficient anyway.
Apparently, when running in emacs and piped into another command, ps limits
it's output to COLUMNS making check_process_names fail. Telling ps to use
wide, wide output with 'ww' fixes this.
Additionally, use check_from so that if this test does fail we can debug
it better, seeing what grep was looking at.
Joshua Marantz