As suggested by Anupama, deflake the test by only allowing beaconing
when explitly requested by http request from tests.
Html with beacons in it will bypass the proxy cache.
- Fix a mistake I made in https://github.com/pagespeed/ngx_pagespeed/pull/653
This is the primary reason the test starts failing, the base fetch
handled `kPreserveOnlyCacheControl` in the wrong way.
- Use `ps_set_cache_control` when copying a Cache-Control header
to nginx, as `r->headers_out.cache_control` is where modules running
after us might expect it
- Exclude a few more lines from curl's verbose output in the keep-
alive tests that I came accross when testing on ubuntu 13.10
Desktop.
Note that this does not deflake the downstream cache test yet, I will
look at that in a follow-up.
There aren't actually any changes required from r3924 to r3934 but the admin
work from previous versions wasn't completely ported before.
This change:
* adds support for /pagespeed_admin and /pagespeed_global_admin
* removes NgxPagespeedConsoleAsyncFetch using NgxBaseFetch instead
* adds options StatisticsPath, GlobalStatisticsPath, ConsolePath,
MessagesPath, AdminPath, and GlobalAdminPath which allow site owners to
control what path these are served under
* changes /ngx_pagespeed_statistics etc from default-on to default-off,
requiring explicit path configuration to function
* does not fix the problem where trunk-tracking fails tests on 1.5 post #653
- Make kPreserveOnlyCacheControl do what it says on the tin
- Serve pagespeed resources with the response headers computed
by PSOL regardless of whether downstream caching is configured.
Fixes https://github.com/pagespeed/ngx_pagespeed/issues/652
Some modules add things to CFLAGS that will make ngx_pagespeed emit
warnings at compile time. For example, nginx-gridfs will add
`--std=c99` - which is no good for ngx_pagespeed.
@peterbowey mentioned that -wno-error fixes the build -- so
to work around, make configure add `-wno-error` when used like
this: `WNO_ERROR=YES ./configure`
On my system, that results in a succesfull build when nginx-gridfs
is added to the module mix.
Fixes https://github.com/pagespeed/ngx_pagespeed/issues/626
Make sure we clear the timeout event associated with resolving
a hostname in `CallbackDone()`, which would otherwise end up
calling `CallbackDone()` a second time upon firing.
Fixes https://github.com/pagespeed/ngx_pagespeed/issues/625
We need to be writing with the base name, with params stripped.
This was causing a test to "flake" under valgrind, since with it we got
to the test showing the bug slowly enough for the entry written out by
an earlier test under proper URL to expire.
Joshua Marantz