artox/incubator-pagespeed-ngx
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

Fix a data race in CacheBatcherTest.

Browse Source
This commit is contained in:
Chris Fredrickson
2016-11-30 14:43:19 -05:00
committed by Steve Hill
parent 3f4df27025
commit 4e3ead31cf
1 changed files with 5 additions and 0 deletions
Download Patch File Download Diff File Expand all files Collapse all files
pagespeed/kernel/cache/cache_batcher_test.cc
Vendored
+5
View File
@@ -433,12 +433,17 @@ TEST_F(CacheBatcherTest, CoalesceDuplicateGetsParallel) {
// n0 is in flight and delayed, but we still have one ready thread to use.
// These gets should not interfere with CacheBatcher's ability to track the
// in flight get of "n0".
//
// (We must delay "n1", to prevent a data race when we make one of its
// fetches invalid.)
DelayKey("n1");
Callback* n1 = InitiateGet("n1");
Callback* not_found = InitiateGet("not_found");
Callback* n2 = InitiateGet("n2");
Callback* not_found_dup = InitiateGet("not_found");
Callback* n1_dup = InitiateGet("n1");
n1_dup->set_invalid_key("n1");
ReleaseKey("n1");
WaitAndCheck(n1, "v1");
WaitAndCheckNotFound(n1_dup); // Check duplicate non-validated hit.