de5bc5d943
Check type of resolver_ctx->addrs.
...
Check the type of resolver_ctx->addrs and make sure that it is
ngx_addr_t* instead of in_addr_t*. addresses issue #839
2014-10-29 14:49:55 -04:00
afd0f01686
script-filters: Allow using script variables in Enable/DisableFilters
...
To support a non-evil way (if-in-location) of tuning SPDY specific
configuration, allow scripting of Enable/DisableFilters in nginx.conf
2014-10-10 17:33:44 +02:00
0cdb81fab4
Merge pull request #795 from pagespeed/oschaaf-native-fetcher-remove-check
...
native-fetcher: remove a DCHECK that possibly fires on shutdown.
2014-10-06 17:04:56 +02:00
b492d3966e
Merge pull request #811 from pagespeed/cheesy-device-matching
...
Support minor PSOL API change for matches_device_type
2014-09-22 17:38:06 -04:00
232c05a81d
Merge remote-tracking branch 'origin/trunk-tracking' into cheesy-device-matching
2014-09-19 18:17:20 -04:00
adbe2cb359
Remove unit tests; They are now in system_test.sh
2014-09-19 18:14:18 -04:00
88370cf54d
Merge pull request #809 from pagespeed/crowell-update-config
...
Merge config from 1.9.32.1
2014-09-19 10:47:08 -04:00
b43a973071
Merge config from 1.9.32.1
2014-09-19 10:30:38 -04:00
a524127d49
PSOL API change and unit tests for matches_device_type
2014-09-18 18:22:46 -04:00
53a6de6da8
Merge pull request #797 from pagespeed/oschaaf-finalized-requests-fix
...
connection_read_handler: fix potential double free
2014-09-15 16:26:29 +02:00
66f1b9aa9b
older-nginx-versions: Add NGX_CONF_MULTI to ps_command flags.
...
Older nginx versions don't allow 'pagespeed' configuration
directives to appear in blocks other then http{} without it.
Fixes https://github.com/pagespeed/ngx_pagespeed/issues/786
2014-09-14 09:19:13 +02:00
6903286aa4
connection_read_handler: fix potential double free
...
In connection_read_handler(), make sure we act accordingly when
r->connection->error is set (indicating the the current request has
been finalized).
Reproduction of what happens when we don't: enable IPRO+SPDY, and
rapidly refresh a page with chrome. These rapid abortions will
eventually trigger a segfault/hang/misc bad behaviour.
2014-09-13 16:30:34 +02:00
46dc39f5a9
Merge pull request #794 from pagespeed/oschaaf-ipro-race
...
IPRO: Fix a race in processing writes() from NgxBaseFetch
2014-09-12 16:33:29 +02:00
7d8fefe780
native-fetcher: remove a DCHECK that possibly fires on shutdown.
2014-09-11 23:33:22 +02:00
43d1706e2f
IPRO: Fix a race in processing writes() from NgxBaseFetch
...
For FetchInPlaceResource, NgxBaseFetch would send two bytes down its
pipe, one upon HeaderComplete() and one upon HandleDone(). We need
only one to resume processing on the nginx side.
There is a race between ps_connection_read_handler() and processing
of the byte send by NgxBaseFetch::HandleDone().
ps_connection_read_handler() clears the pipe when the request is
finalized, and also drains it on each event - so two writes could be
processed as one when lucky, masking the problem).
One concrete problem this solved for me was that SPDY + IPRO +
proxy_pass would segfault, hang, and/or pass on 5xx/404 responses
from IPRO lookup fetches to the browser, next to alerts about
r->count being zero in nginx's error.log
Might fix https://github.com/pagespeed/ngx_pagespeed/issues/788
Fixes https://github.com/pagespeed/ngx_pagespeed/issues/792
2014-09-11 23:14:41 +02:00
622d088a3e
Merge pull request #790 from pagespeed/oschaaf-trunk-tracking-native-fetcher-keepalive
...
native fetcher: Support http keep-alive
2014-09-05 17:29:22 +02:00
0290f52a88
native fetcher: Support http keep-alive
...
Based on @dinic his work, add keep-alive support for the native fetcher.
Adds a new option, usable at the http{} level in configuration:
pagespeed NativeFetcherMaxKeepaliveRequests 50;
The default value is 100 (aligned to nginx). Setting the value to 1 turns off
keep-alive requests altogether).
Most notable changes:
- Request keep-alive by adding the appropriate request header
- Fixes connections getting reused while they are servicing other requests:
- Remove connection from the pool of available connections for keepalive when applicable
- Disable keepalive in more appropriate situations
- Response parsing fixes
- Remove connections that timeout from the k.a. pool
- Add a few sanity (D)CHECKS
- Emit debug messages for traceability
- Fix for ignoring ipv6 addresses returned from dns queries when ipv6 is enabled.
- Bump the fetch timeout in test configuration to deflake tests that require dns
lookups (which will be done via 8.8.8.8 currently for the native fetcher)
2014-09-05 17:23:16 +02:00
c94146a54d
Merge pull request #791 from pagespeed/morlovich-trunk-tracking-remove-deprecated-headers
...
Remove use of deprecated forwarding headers
2014-09-04 16:06:52 -04:00
f3a1cb6cf4
Remove use of deprecated forwarding headers
2014-09-04 09:16:05 -04:00
5a23347e64
Merge pull request #785 from pagespeed/jmarantz-error-option-format
...
Implement NgxServerContext::FormatOption so we can indicate nginx formatting in error messages
2014-08-29 16:32:43 -04:00
7ce289346a
Override the method used to specify the format for conf files, so we can put an accurate error message in the admin GUI, and test it
2014-08-29 09:13:43 -04:00
6b4a9dc487
Merge pull request #784 from pagespeed/jmarantz-fgrep-for-counts
...
use fgrep for counting ".pagespeed."
2014-08-27 09:47:46 -04:00
a3f2e4766c
use fgrep for counting ".pagespeed.", rather than grep with backslashed dot, which matches too much
2014-08-26 15:02:10 -04:00
ab0a5e4b65
Merge pull request #782 from pagespeed/jmarantz-start-test-resets-wget-args
...
Assume WGET_ARGS is cleared on every start_test
2014-08-23 13:20:34 -04:00
a458a65d4e
Update system test to be compatible with a helper-script update that makes start_test clear WGET_ARGS, making test stanzas more independent
2014-08-20 12:59:04 -04:00
d00911b00f
Merge pull request #775 from pagespeed/jefftk-clearer-test-flake-error
...
testing: make it clearer why test flake in Issue #774 happens
2014-08-14 11:34:50 -04:00
ed80427ae6
Merge pull request #761 from pagespeed/jefftk-adding-comments
...
Add some comments and a few style fixes.
2014-08-14 10:29:22 -04:00
f556ca4926
Add some comments and a few style fixes.
2014-08-14 09:52:13 -04:00
cad618dff7
testing: make it clearer why test flake in Issue #774 happens
2014-08-13 13:53:22 -04:00
a906411367
Merge pull request #773 from pagespeed/jefftk-nginx-message-color
...
testing: direct port of r4146 to fix message color issue
2014-08-13 10:51:37 -04:00
e6c5bc1b2e
testing: direct port of r4146 to fix message color issue
2014-08-13 10:13:13 -04:00
d6d3b90ea3
Merge pull request #769 from pagespeed/oschaaf-large-beacon-posts
...
beacon response body processing from temp file
2014-08-12 17:57:34 +02:00
d7afd2acbc
beacon response body processing from temp file
...
Add support for processing beacon posts with data sizes that exceed
the default or configured client_body_buffer_size, plus a system test
to ensure it.
Fixes https://github.com/pagespeed/ngx_pagespeed/issues/752
2014-08-12 07:46:30 +02:00
05f6993801
Merge pull request #772 from pagespeed/morlovich-fix-metadata-form-test
...
Port over test adjustment.
This is just a straight port of relevant portion of https://code.google.com/p/modpagespeed/source/detail?r=4140
2014-08-11 16:45:32 -04:00
fe63bbf53f
Port over test adjustment.
2014-08-11 16:26:20 -04:00
c7aa72d9c5
Merge pull request #767 from pagespeed/oschaaf-issue-757
...
rewriting-posts: Support POST responses for html
2014-08-07 16:28:51 +02:00
8f6bb0c9e3
rewriting-posts: Support POST responses for html
...
Allow rewriting html responses to POST requests
Fixes https://github.com/pagespeed/ngx_pagespeed/issues/757
2014-08-07 16:02:23 +02:00
84f2a1884e
Merge pull request #765 from pagespeed/oschaaf-trunk-tracking-script-support
...
script-variables: Support LoadFromFileXXX
2014-08-05 16:45:19 +02:00
da83f73f19
script-variables: Support LoadFromFileXXX
...
Based on 75a4481https://github.com/pagespeed/ngx_pagespeed/issues/549
Docs: https://github.com/pagespeed/ngx_pagespeed/wiki/Script-variables-in-LoadFromFile-configuration
Resolved conflicts:
src/ngx_rewrite_driver_factory.h
src/ngx_rewrite_options.cc
test/nginx_system_test.sh
2014-08-05 00:51:07 +02:00
2bfc05b4c6
Merge pull request #763 from pagespeed/jmarantz-http-200-ok-function
...
use a new helper method to verify HTTP response codes are 200 OK
2014-08-04 11:00:03 -04:00
ea9e209687
Merge pull request #764 from pagespeed/jmarantz-systest-exit-on-error
...
Make script execute properly in the context of 'set -e'
2014-08-04 10:04:03 -04:00
c073a3120b
remove debug comments
2014-08-04 10:02:31 -04:00
5e3b2f23a5
Make script execute properly in the context of 'set -e'
2014-08-01 09:29:08 -04:00
f41ecf4010
use a new helper method to verify HTTP response codes are 200 OK
2014-08-01 09:19:40 -04:00
34a62db9cf
Merge pull request #760 from pagespeed/sligocki-request-context-set-options
...
Set options for RequestContexts in ngx_pagespeed.
2014-07-30 09:53:00 -04:00
b0efa9f982
Merge pull request #758 from pagespeed/crowell-debug-filter-safe-to-print
...
add safe_to_print on nginx rewrite options
2014-07-29 16:58:10 -04:00
fb00ac373b
Set options for RequestContexts in ngx_pagespeed.
2014-07-29 16:05:27 -04:00
9550629768
add safe_to_print on nginx rewrite options
2014-07-29 14:58:06 -04:00
26a5deb341
Merge pull request #756 from pagespeed/sligocki-in-place-api-change
...
Fix InPlaceResourceRecorder constructor to remove two arguments passed in through options now.
2014-07-29 13:09:44 -04:00
7bcd5aadde
Fix InPlaceResourceRecorder constructor to remove two arguments passed in through options now.
2014-07-28 18:02:17 -04:00
Jeffrey Crowell