60c1f4cc4e
Fix valgrind complaint caused by NgxBaseFetch
...
We should not use r->connection after we finalize the request.
Fixes https://github.com/pagespeed/ngx_pagespeed/issues/1100
2016-01-22 16:06:42 +01:00
b88e067c6d
Eliminate CHECK that fails (rarely) during the IPRO lookup.
...
Fixes https://github.com/pagespeed/ngx_pagespeed/issues/1096
2016-01-21 22:08:43 +01:00
b214fb43e3
Merge pull request #1061 from pagespeed/oschaaf-trunk-tracking-add-resource-header
...
AddResourceHeader: Add test configuration
2016-01-19 13:26:01 -05:00
9e6048f771
Merge pull request #1092 from pagespeed/jmarantz-ipro-flow-cache-not-flaky
...
remove 'IPRO flow uses cache as expected' from flaky-list, ...
2016-01-05 15:11:46 -05:00
653875cb68
Merge pull request #1076 from pagespeed/morlovich-h2-bit
...
Store whether h2 is in use in RequestContext.
2016-01-05 12:35:51 -05:00
a512d95258
remove 'IPRO flow uses cache as expected' from flaky-list, but strip out 'Fetch timed out' from log-warning check
2016-01-05 11:46:35 -05:00
a4441220b1
Merge pull request #1085 from pagespeed/oschaaf-trunk-tracking-internal-redirect-crasher
...
Fix crasher on 404 .pagespeed. resources w/a custom location
2016-01-04 22:03:05 +01:00
374ee1c750
Merge pull request #1089 from pagespeed/crowell-reapply-744
...
reapply: location-header: tweak location header handling
2015-12-31 10:54:29 -05:00
059dd20b10
reapply: location-header: tweak location header handling
...
- Fix potentially sending the location header into PSOL twice.
- Be more thorough when unsetting the location header
Attempts to fix #725
from oschaaf
2015-12-31 10:46:39 -05:00
1964ef5219
Fix crasher on 404 .pagespeed. resources w/a custom location
...
- Fix nginx-side flow so we handle .pagespeed. resources ok
when they will land on a customized 404 internal location.
- Additionally, check for a wiped request context and make sure
we do not dereference a null pointer, which is what hurt in
the flow we entered above as the IPRO lookup still was
generating events while the nginx side request context was
gone.
- Also, as a preliminary measure, do not check fail when we
receive a stale event originating from a NgxBaseFetch that
is no longer associated with our request context.
Do log a warning so we'll hear about this happening either
through system test failures or a bug report.
Fixes https://github.com/pagespeed/ngx_pagespeed/issues/1081
2015-12-28 15:59:13 +01:00
56a5d41ec3
Restore dropped fix for #957
...
@rfnx fixed #957 in acb89a, but this was accidentally merged to master
instead of trunk-tracking. I checked for this sort of problem as part
of the 1.10 release, but missed this commit. Restored.
Fixes #1054
2015-12-18 15:01:15 -05:00
7ee1efe0dd
Merge pull request #1071 from pagespeed/oschaaf-trunk-tracking-log-debug-noise
...
log: initialize logging earlier
2015-12-17 11:36:34 -05:00
eb2a81ee79
Store whether h2 is in use in RequestContext.
2015-12-15 09:29:02 -05:00
37e1c3618a
log: initialize logging earlier
...
It turns out to be possible to initialize logging earlier by
grabbing the log from a global ngx_cycle structure.
This makes us start logging earlier, yet loses the
"No threading detected ..." messages both from stderr and
in error.log when nginx initially starts.
With this change, these messages will now be logged as we start
logging earlier:
"
flush
.
"
These originate from SystemCachePath::CacheKey which appends
newlines to the key, and the resulting cache key ends up being
logged. We might want to change that, because the resulting
lines in error.log look weird and might raise questions.
Fixes https://github.com/pagespeed/ngx_pagespeed/issues/895
2015-12-11 12:02:21 +01:00
df498ea788
Merge pull request #1067 from pagespeed/crowell-fix-gcc5
...
add flags for new GCC on config tests
2015-12-10 15:45:47 -05:00
4b4d353156
add flags for new GCC on config tests
...
closes #1066
2015-12-10 15:41:44 -05:00
c9d4912746
Merge pull request #1050 from pagespeed/morlovich-compiler-req
...
Add compiler version checks for what we want to support going forward.
Also make us actually build with clang (the log_message_handler.cc change
and config.make change)
2015-12-09 14:50:11 -05:00
2b74f6bed3
AddResourceHeader: Add test configuration
...
nps side of https://github.com/pagespeed/mod_pagespeed/pull/1200
2015-12-09 04:35:24 +01:00
f1a6cd0ade
Whitespace tweak
2015-12-07 10:01:23 -05:00
0c01c0644e
Merge pull request #1057 from pagespeed/jmarantz-2-pass-ipro
...
suppress errors on new 2-pass and 3-pass ipro tests
2015-12-02 16:45:48 -05:00
14aa4fd962
suppress errors on new 2-pass and 3-pass ipro tests
2015-12-02 15:01:37 -05:00
36a7ff9543
Merge pull request #1056 from pagespeed/jmarantz-no-error-on-slow-ReadFile
...
do not consider it a test failure to get a slow ReadFile operation.
2015-12-02 08:31:34 -05:00
706577a34b
do not consider it a test failure to get a slow ReadFile operation.
2015-12-02 08:27:47 -05:00
6703b2d76e
Merge pull request #1055 from pagespeed/oschaaf-trunk-tracking-location-header-handling
...
location-header: Be careful with headers_out->location
2015-12-01 18:56:53 +01:00
40c05b4a4f
location-header: Be careful with headers_out->location
...
Only set headers_out->location when the upstream originally did
as well. If the Location: header value involved starts with "/"
nginx will absolutify it, ignoring any X-Forwarded-Proto header
in the process.
Fixes https://github.com/pagespeed/ngx_pagespeed/issues/819
(Confirmed: https://github.com/pagespeed/ngx_pagespeed/issues/1029 )
Hopefully fixes https://github.com/pagespeed/ngx_pagespeed/issues/711
2015-12-01 18:55:02 +01:00
bc875647f1
Add compiler version checks for what we want to support going forward,
...
and make us actually build with clang (the log_message_handler.cc change
and config.make change)
2015-11-25 13:44:13 -05:00
f88a0763fd
Merge pull request #1048 from pagespeed/morlovich-buildflag
...
Pass in -D_GLIBCXX_USE_CXX11_ABI=0, so people using gcc-5.x can use our psol.a
2015-11-25 08:56:16 -05:00
239ca9aa80
Pass in -D_GLIBCXX_USE_CXX11_ABI=0, so people using gcc-5.x can use psol.a
...
we built with 4.8
See issue 942
2015-11-24 15:16:06 -05:00
37c51d3b9e
Merge pull request #1042 from pagespeed/jefftk-content-experiment
...
Add ContentExperiment support
2015-11-24 11:46:04 -05:00
2468257e2d
Add ContentExperiment support
2015-11-20 16:39:02 -05:00
4628e1c0ea
Merge pull request #1035 from pagespeed/jefftk-script-var-testing
...
Support script variables in ShardDomain
2015-11-19 11:01:41 -08:00
7f98ab448b
Merge pull request #1047 from pagespeed/jefftk-ngx-brotli
...
Fix interaction with ngx_brotli module.
2015-11-18 11:20:17 -08:00
103c479fbb
Fix interaction with ngx_brotli module.
...
Reported by George Liu (eva2000) on GitHub (issue #1021 ).
Signed-off-by: Piotr Sikora <piotrsikora@google.com >
Conflicts:
config
2015-11-16 18:26:30 -05:00
887bd8fa98
Merge pull request #1046 from pagespeed/crowell_content_encoding
...
add content_encoding to headers_out
2015-11-16 11:09:04 -05:00
804f234268
add remaining shortcuts to headers_out_t
...
this change is required for gzip cache change going into mod_pagespeed.
2015-11-16 10:56:23 -05:00
ea82f0de19
Support script variables in ShardDomain
2015-11-02 10:08:00 -05:00
5f312820e5
Merge pull request #974 from pagespeed/jefftk-handler-restrictions
...
Add support for blocking access to our handlers.
2015-11-02 08:18:10 -05:00
7efac4ac4e
Merge pull request #1028 from pagespeed/oschaaf-trunk-tracking-issue-1015
...
IPRO+MPD: Make In-Place-Resource-Optimization with MapProxyDomain work
2015-10-28 13:30:04 -04:00
634b813071
IPRO+MPD: Make In-Place-Resource-Optimization with MapProxyDomain work
...
Fixes https://github.com/pagespeed/ngx_pagespeed/issues/1015
Pull with MPS Side for this change:
https://github.com/pagespeed/mod_pagespeed/pull/1161
2015-10-27 18:11:35 +01:00
d30972985b
Merge pull request #1026 from pagespeed/jmarantz-remove-set-ua
...
Don't call RewriteDriver::SetUserAgent on the UA in the request-headers.
2015-10-22 15:17:15 -04:00
3a6e833eae
Don't call RewriteDriver::SetUserAgent on the UA in the request-headers.
...
RewriteDriver::SetRequestHeaders already pulls the UA from the request-headers.
2015-10-22 14:19:00 -04:00
90c8ac8a12
Revert "Don't call RewriteDriver::SetUserAgent as the user-agent is already in the request-headers"
...
This reverts commit 6ccc1c513b
2015-10-22 14:13:01 -04:00
6ccc1c513b
Don't call RewriteDriver::SetUserAgent as the user-agent is already in the request-headers
2015-10-22 13:20:00 -04:00
fe47eeb4f3
Add support for blocking access to our handlers.
...
Nginx side of the fix for https://github.com/pagespeed/mod_pagespeed/issues/1088
2015-09-18 09:03:01 -04:00
e42f61e263
Merge pull request #1002 from pagespeed/jmarantz-log-slow-file-ops
...
ignore errors about slow file operations
2015-07-31 17:01:39 -04:00
8bac32c669
ignore errors about slow file operations, which can occur when running valgrind tests
2015-07-31 16:57:20 -04:00
4bef2af22c
Merge pull request #995 from pagespeed/crowell-disable-sendfile
...
add test servers for sending x-sendfile and x-accel-redirect
2015-07-23 17:34:58 -04:00
52bd966edd
add test servers for sending x-sendfile and x-accel-redirect
2015-07-23 13:34:25 -04:00
0f7a1f4503
Merge pull request #994 from pagespeed/jefftk-allow-script-variables
...
config: whitelist a few more directives for script variables
2015-07-23 10:36:57 -04:00
7f477d6575
config: whitelist a few more directives for script variables
...
When configuring downstream caching if you have an origin with multiple caches in front of it you might want to choose how you handle requests in response to which cache you're getting them from. Whitelist DownstreamCachePurgeLocationPrefix, DownstreamCachePurgeMethod, and DownstreamCacheRewrittenPercentageThreshold for scripting so this is possible.
2015-07-22 10:32:41 -04:00
Otto van der Schaaf