Commit Graph

544 Commits

Author SHA1 Message Date
Shawn Ligocki c72247b6dc Add option for cutomizable responsive image densities (default still 1.5,2). 2015-05-18 11:35:47 -04:00
Shawn Ligocki 28d6bbcf62 genfiles 2015-05-18 11:34:33 -04:00
Shawn Ligocki 6c78f97f5a Add versioning to HTTPCache, so that we can flush it.
Flush HTTP and Metadata Cache because of potential poisoning from Issue 1050.
2015-05-15 16:58:53 -04:00
Shawn Ligocki b8e6b713f9 genfiles 2015-05-15 16:58:26 -04:00
Jeff Kaufman 0b399cc1f2 Fix https://github.com/pagespeed/mod_pagespeed/issues/1078 by removing a DCHECK for valid image dimensions. 2015-05-14 15:28:28 -04:00
Jud Porter 13cdc14a67 Use 100% sizing for iframe mode. 2015-05-14 09:45:34 -04:00
Jan-Willem Maessen 219c18b895 Clean up uses of pagespeed attributes to use a bare attribute rather than
passing the empty string.
2015-05-13 17:28:24 -04:00
Jeffrey Crowell e85528a898 genfiles 2015-05-12 16:25:05 -04:00
Shawn Ligocki 78da6f4710 Fix srcset parsing in responsive.js. Specfically, deal with the fact that URLs may contain commas in the middle. Add a lot more testing for whitespace and comma potential corner cases. 2015-05-11 17:34:30 -04:00
Jan-Willem Maessen 4ecd07606e Store mobile labelings in the property cache. Also refresh the mobilization js. 2015-05-07 18:28:33 -04:00
Jeffrey Crowell 3e8dcb18c4 genfiles 2015-05-06 13:51:12 -04:00
Shawn Ligocki 8f93d5cefc Do not rewrite nor cache empty resources.
While there is nothing technically wrong with caching and rewriting empty resources, there's not much value and we have run into situations where we unexpectedly produce empty resources.

Fixes issue 1050.
2015-05-01 17:16:26 -04:00
Maks Orlovich 1e5edecc31 Make sure to also apply domain suffix to css and scripts.
This is in particular important for css in case there are any @font-face rules,
since those have strict cross-domain restrictions.
2015-04-30 15:02:44 -04:00
Maks Orlovich 18a15d1ca7 Make NoGoogleFontCssInlineFilterAndWidePermissionsTest.WideAuthorization actually
test what it was supposed to test.
2015-04-30 14:18:50 -04:00
Shawn Ligocki e6aee72310 Wire up failure reason in InlineRewriteContext. This exposes that a google fonts test is failing for 4xx resource fetch when we expected it to fail because resource isn't cacheable. 2015-04-29 13:43:49 -04:00
Shawn Ligocki d55259fb73 Drop dependence of RewriteDomainTransformer on RewriteDriver,
since I want to use it (via upcoming DomainRewriteFetch) in
ApacheSlurp. (morlovich)
2015-04-29 13:43:20 -04:00
Shawn Ligocki b65e4e03db genfiles 2015-04-29 13:42:19 -04:00
Jud Porter d6753694a2 Improve mob rendering on desktop. 2015-04-27 10:38:21 -04:00
Joshua Marantz ff6d9739ac Fixes mobilize-iframe mode from a proxy. 2015-04-27 09:41:00 -04:00
Maks Orlovich 1b9011d078 Add an API to incrementally rewrite URLs in CSS delivered in chunks.
(Potentially retaining some unparsed pieces for the next chunk).
2015-04-24 13:53:42 -04:00
Joshua Marantz 97192f19e3 Fix spelling for DomainRewriteCookies option. 2015-04-24 13:09:10 -04:00
Joshua Marantz d21964af53 Ensure ComputeCaching is called when optimized inline resources are created. 2015-04-24 11:02:10 -04:00
Joshua Marantz 94c5478869 Update for js compiler change. 2015-04-23 15:56:47 -04:00
Maks Orlovich 59afeab08c Remove needless argument for CssTagScanner constructor, and static'ify
some methods that don't need state (since other methods will benefit
from having state more).
2015-04-23 11:27:54 -04:00
Jud Porter f6d2bcf064 Fix some build warnings and update compiled JS. 2015-04-22 21:46:03 -04:00
Joshua Marantz 2c1f9e90a9 Remove spurious log message during tests 2015-04-22 16:40:03 -04:00
Jeffrey Crowell 6e24e6c85d genfiles 2015-04-20 11:28:39 -04:00
Shawn Ligocki b18a06426e Cleanup noticed while working on GoogleUrl::Sanitize():
* Rename GoogleUrl::Escape() -> EscapeQueryParam(), Unescape() -> UnescapeQueryParam() to clarify their limited scope.
* Change GoogleUrl::CopyAndAddEscapedQueryParam() -> CopyAndAddQueryParam() and do the escaping in the function, this seems like a safer and easier interface to use and most callsites were explicitly calling the escaper anyway.
* const StringPiece& -> StringPiece
* Add some more tests for CopyAndAddEscapedQueryParam().
2015-04-17 17:12:40 -04:00
Shawn Ligocki 3b8db3d1e4 Re-configure srcset resolutions. Add 1.5 because 1.5x and 2x seem very common resolutions. (My Moto X is 1.5x and AFAICT many android phones are as well). Drop 4x, since AFAICT there are no 4x devices. 2015-04-17 13:52:34 -04:00
Shawn Ligocki 994dd36ca3 Fix a few small bugs noticed when streamifying this, and comment + testcase one thing that's not actually a bug.
(Split off since I felt mixing it in would make for a harder review). (morlovich)
2015-04-17 13:40:15 -04:00
Shawn Ligocki 6b47f8dde7 genfiles 2015-04-17 13:39:33 -04:00
Jan-Willem Maessen 18254110b9 Add missed in last commit. 2015-04-17 11:32:53 -04:00
Jan-Willem Maessen 0837440eff Move mobilize_label to use a proto to store its labeling. 2015-04-16 18:04:54 -04:00
Maks Orlovich 1f14cd7f60 Fix some bugs in fallback CSS rewriter 2015-04-16 17:30:54 -04:00
Jan-Willem Maessen 2444fa78cf Fix the problem with server-side mobilization deployment. The problem was that
the background fetch was trying to run mobilize_label_filter, but that filter
was failing to label the DOM elements because
driver()->request_properties()->IsMobile() was false for the subfetch (though it
was true for the enclosing page).
2015-04-13 19:14:36 -04:00
Jan-Willem Maessen c51550b8a4 Shorten very long menu entries by dropping text at natural boundaries in the DOM. 2015-04-10 19:01:42 -04:00
Jeffrey Crowell fe6410b0e2 +x to all of the scripts 2015-04-09 14:59:01 -04:00
Shawn Ligocki f04b8d4145 Escape all whitespace in URLs before putting them in srcsets. Also check that they don't begin or end with a comma (unfortunately comma is a reserved char for URLs ... I'm not sure exactly why, but that means that escaping them could potentially change the meaning of the URL.
Added a new GoogleUrl::Sanitize function to help for general cases where this comes up (we need to make sure that a URL is free of whitespace, '"' and other chars which may be safely escaped).
2015-04-09 14:42:31 -04:00
Shawn Ligocki 8048715660 genfiles 2015-04-09 14:27:28 -04:00
Joshua Marantz 93e0eb71f2 Use firstElementChild and nextElementSibling as appropriate to clean
up the layout traversal code.
2015-04-08 16:15:03 -04:00
Jan-Willem Maessen c1aa4eed35 Fix bug where top-level nav in one region without <ul> would get used as the
title of a <ul> nav in the next navigational DOM
2015-04-08 14:56:40 -04:00
Jeffrey Crowell eb8fb1fdbb generate menus server-side
commit from jmaessen:

Generate menus on the server side using mobilize_menu_render_filter doing a
second fetch of the HTML in the background and running mobilize_label_filter and
mobilize_menu_filter on the results.  Inject the navigation bar on the server
side and adapt the mobilize_nav.js to properly handle the prsence of these
elements on the rewritten page.
2015-04-07 16:03:53 -04:00
Jeffrey Crowell e2b900392e dump genfiles 2015-04-07 16:01:29 -04:00
Jeffrey Crowell 802418a8ad move everything from src to root 2015-04-06 11:29:33 -04:00