From 81029dafa6d71cf6a3bad8221755b63eceb37283 Mon Sep 17 00:00:00 2001 From: Jeffrey Crowell Date: Fri, 30 Jan 2015 10:23:00 -0500 Subject: [PATCH] Replace CHECK with return failure and log. Fixes #888 along with https://code.google.com/p/modpagespeed/source/detail?r=4533 --- src/ngx_pagespeed.cc | 5 ++++- 1 file changed, 4 insertions(+), 1 deletion(-) diff --git a/src/ngx_pagespeed.cc b/src/ngx_pagespeed.cc index eb6877c09..f4d35b3bd 100644 --- a/src/ngx_pagespeed.cc +++ b/src/ngx_pagespeed.cc @@ -1661,7 +1661,10 @@ ngx_int_t ps_resource_handler(ngx_http_request_t* r, GoogleString url_string = ps_determine_url(r); GoogleUrl url(url_string); - CHECK(url.IsWebValid()); + if (!url.IsWebValid()) { + ngx_log_error(NGX_LOG_ERR, r->connection->log, 0, "invalid url"); + return NGX_DECLINED; + } scoped_ptr request_headers(new RequestHeaders); scoped_ptr response_headers(new ResponseHeaders);